Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading refs concurrently #91

Open
gskierk opened this issue Dec 26, 2024 · 1 comment
Open

Reading refs concurrently #91

gskierk opened this issue Dec 26, 2024 · 1 comment

Comments

@gskierk
Copy link

gskierk commented Dec 26, 2024

Reading 29 refs (using "op read" one by one) now takes 20-25 seconds. It would be great if we could cut this time by reading all refs concurrently (Promise.all?). Reading them this way takes around 2-3 seconds. Is it possible to implement in this action?

@jb1p
Copy link

jb1p commented Dec 26, 2024

Hi @gskierk thank you for your suggestion! I believe this is a good optimization to add. The community is currently working to transition from the op CLI to using the SDK directly, which you can follow here: #80 #82

Once that effort is complete, this suggestion could be implemented by tweaking the code in extractSecrets to fetch all references simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants