Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable notifications #86

Open
bfil opened this issue Mar 24, 2017 · 6 comments
Open

Add option to disable notifications #86

bfil opened this issue Mar 24, 2017 · 6 comments

Comments

@bfil
Copy link

bfil commented Mar 24, 2017

It might just be me, but I find the notifications shown by this package a little bit invasive and not very useful when activating the "build on save" flag, the "Building project" info notification is quite distracting in this case, when all I care about is the feedback from the linter to be displayed.

When doing TDD and using test as the build action if there are test failures it gets even worse, with panics and "test failed" error notifications popping out everywhere.

In most cases, from my workflow point of view the linter feedback and the green/red feedback at the bottom left of the editor are enough for me to know what's going on with "build on save" turned on, and if I need the details I can just decide to show the output panel on error for example.

For these reasons I would say it would be great to have the option to disable the notifications in the preferences. For now, I just hacked it in the source folder and removed the notifications code and everything looks great to me.

Would you be open to supporting this?

I know there are plans to make notifications less intrusive in Atom itself (atom/notifications#29) but would still be great to have the option for now imo.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 24, 2017

I don't think this is something we can do in build-cargo, since these messages are produced by the build package.

@bfil
Copy link
Author

bfil commented Mar 24, 2017

@oli-obk
Copy link
Contributor

oli-obk commented Mar 24, 2017

Ah... well the alternative is that these messages get swallowed without showing up anywhere (since these messages don't have a span for showing an inline lint)

The output panel is pretty much useless when using the json errors

@bfil
Copy link
Author

bfil commented Mar 24, 2017

Oh yeah well, I've disabled the JSON errors in the panel so I see the human readable output when I bring it up.

@Tectract
Copy link

I'm getting notifications about the file names of the file I am viewing when switching tabs. I would like an option to disable ALL NOTIFICATIONS in Atom. I hate notifications, they are extremely intrusive popups and do nothing but distract me and slow me down.

@achimbode
Copy link

For people who stumble upon this thread trying to get rid of the annoying popups - this package seems to do the job: notifications-plus.
I think there is a difference between the possibility of keeping track of errors of all kinds (sometimes thrown by extensions that I need and that apart from the errors work fine) and scattering the whole screen with it. This package allows for both at once. Thanks a lot to UziTech for sharing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants