Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Performance #1074

Open
AryazE opened this issue Sep 12, 2024 · 5 comments
Open

Improve Performance #1074

AryazE opened this issue Sep 12, 2024 · 5 comments

Comments

@AryazE
Copy link
Contributor

AryazE commented Sep 12, 2024

https://github.com/AtsushiSakai/PythonRobotics/blob/ad600cd9023e67cd8064b678213d6586d076dd15/PathPlanning/AStar/a_star_searching_from_two_side.py#L80C1-L117C20

In the above function the search for coordinates and neighbors in ob_list and neighbors happens very often, specially for long obstacles.
It would be more efficient to store the obstacles and neighbors in a set as the lookup is done by a hashmap instead of a linear search.

@prajwal2431
Copy link

is this issue still open i want to contribute to this issue

@AtsushiSakai
Copy link
Owner

PR is welcome.

@Mritunjaii
Copy link

@AtsushiSakai can you assign me

@AtsushiSakai
Copy link
Owner

no need to assign. please create a PR.

@Mritunjaii
Copy link

@AtsushiSakai check pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants