I discovered an error in the changes made in commit 03a6cbc5a5187e90f265b11841854afd9cfe7c54. The issue is that the scaling factor was not added to the symbol: #1753
Replies: 3 comments
-
Additionally, I noticed that there is only a visual effect, but no sustain effect during playback. I'm not sure if this is the current situation. |
Beta Was this translation helpful? Give feedback.
-
https://github.com/CoderLine/alphaTab/blob/develop/src/platform/svg/CssFontSvgCanvas.ts#L51 Why do you think it is wrong? Did you notice any wrong rendering?
Yes, for now this is on purpose. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
I discovered an error in the changes made in commit 03a6cbc. The issue is that the scaling factor was not added to the symbol:
at:\src\rendering\glyphs\SustainPedalGlyph.ts
if (marker.pedalType === SustainPedalMarkerType.Down) { canvas.fillMusicFontSymbol(markerX, y + h, 1, MusicFontSymbol.KeyboardPedalPed, true); linePadding = (SustainPedalGlyph.TextWidth / 2) * this.scale + SustainPedalGlyph.TextLinePadding * this.scale; } else if (marker.pedalType === SustainPedalMarkerType.Up) { canvas.fillMusicFontSymbol(markerX, y + h, 1, MusicFontSymbol.KeyboardPedalUp, true);
In this part, the line:
canvas.fillMusicFontSymbol(markerX, y + h, 1, MusicFontSymbol.KeyboardPedalPed, true);
should be changed to:
canvas.fillMusicFontSymbol(markerX, y + h, this.scale, MusicFontSymbol.KeyboardPedalPed, true);
Similarly, the latter part should also change 1 to this.scale.
Beta Was this translation helpful? Give feedback.
All reactions