Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chromium] Add support for "Find in page" #1481

Open
svillar opened this issue Jul 15, 2024 · 1 comment
Open

[Chromium] Add support for "Find in page" #1481

svillar opened this issue Jul 15, 2024 · 1 comment
Labels
chromium Issues related to the new Chromium backend enhancement New feature or request

Comments

@svillar
Copy link
Member

svillar commented Jul 15, 2024

It's already implemented in Gecko

It's a matter of implementing the SessionFinder interface for Chromium
@svillar svillar added enhancement New feature or request chromium Issues related to the new Chromium backend labels Jul 15, 2024
@haanhvu
Copy link
Collaborator

haanhvu commented Nov 18, 2024

I'm working on this. I saw we have the interface in https://github.com/Igalia/wolvic/blob/main/app/src/common/shared/com/igalia/wolvic/browser/api/WSession.java and the Gecko implementation in https://github.com/Igalia/wolvic/blob/main/app/src/common/gecko/com/igalia/wolvic/browser/api/impl/SessionFinderImpl.kt Do you have any guides for the Chromium implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chromium Issues related to the new Chromium backend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svillar @haanhvu