Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MvNormal(::FiniteGP) in a @requires #167

Open
cscherrer opened this issue Oct 20, 2021 · 0 comments
Open

Add MvNormal(::FiniteGP) in a @requires #167

cscherrer opened this issue Oct 20, 2021 · 0 comments

Comments

@cscherrer
Copy link
Collaborator

It's not necessary to compute it if you don't call rand or logpdf shrug

One approach that doesn't touch the structure of FiniteGP would be to add a method MvNormal(::FiniteGP) that returns the corresponding MvNormal distribution which could then be used instead of FiniteGP if you don't want to recompute the cholesky decomposition, e.g., if you call rand or logpdf multiple times.

Ooh, I like that. Maybe we have a @require in MeasureTheory that adds the MvNormal method. Then we can use the faster representation too, should work out great!

Originally posted by @cscherrer in JuliaGaussianProcesses/AbstractGPs.jl#232 (comment)

What do you think @mschauer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant