Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #121: Add REPL to weakdepends in temp Manifest #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #121: Add REPL to weakdepends in temp Manifest #125

wants to merge 1 commit into from

Conversation

pjaap
Copy link

@pjaap pjaap commented Dec 10, 2024 •
edited
Loading

This should fix #121

Steps to reproduce the previous failure:

$ git clone https://github.com/pjaap/TestPackage.jl # simple package with a single unit test
$ julia
] activate @v1.11
] add TestReports
] activate TestPackage.jl
julia> using TestReports
julia> TestReports.test("TestPackage") # crash

Adding TestReports in the TestPackage environment does not create a crash.

@pjaap pjaap mentioned this pull request Dec 10, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (54191fb) to head (1d232de).
Report is 25 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   96.40%   93.38%   -3.03%     
==========================================
  Files           7        7              
  Lines         557      484      -73     
==========================================
- Hits          537      452      -85     
- Misses         20       32      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashing on Julia 1.11-rc1
1 participant
@pjaap