Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images/sounds not working correctly due to changing from kasandbox to kastatic urls #747

Open
Steffan153 opened this issue Mar 4, 2021 · 4 comments

Comments

@Steffan153
Copy link

A lot of programs aren't working anymore because for some reason, KA is using kastatic.org URLs instead of kasandbox.org.

For example, a sound URL KA used to use: https://www.kasandbox.org/programming-sounds/rpg/metal-clink.mp3
What it uses now (this link is broken): https://cdn.kastatic.org/third_party/javascript-khansrc/live-editor/sounds/rpg/metal-clink.mp3

Or image URL: https://www.kasandbox.org/programming-images/animals/fox.png to https://cdn.kastatic.org/third_party/javascript-khansrc/live-editor/build/images/animals/fox.png

So that's one thing, the new sound URLs don't even work.

But for images, the image URLs work, and image()/getImage() seem to work, but then when you try to call get() after displaying an image, it errors.

@MatthiasPortzel
Copy link
Contributor

MatthiasPortzel commented Mar 7, 2021

Bumping this. All sounds are broken and using images taints the canvas with cross-site content. I don't know who at KA if anyone is in charge of fixing bugs in this repo, but it would be appreciated to give us an acknowledgement that this is a known issue. @jeresig @pamelafox

(OurJSEditor allows you to load sounds from anywhere, so it doesn't have these issues.)

@pamelafox
Copy link
Collaborator

I'm not currently working at Khan Academy, have you also filed a ticket at https://khanacademy.zendesk.com/hc/en-us/requests/new?ticket_form_id=261028 ? That typically raises the priority of issues for the engineering team.

I suggest also linking to programs that worked before and no longer work.

@Steffan153
Copy link
Author

I'll do that.

There are 100s of programs that are broken actually. I could link to some though.

@MatthiasPortzel
Copy link
Contributor

This seems to have been rolled back a couple of days ago, and is currently working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants