[MyPerf4J-90] Fix SysGenProfilingFile rename fail #90 #91

JiaRG · 2023-04-02T07:45:45Z

What is the purpose of the change

fix #90

Brief ChangeLog

fix SysGenProfilingFile rename fail

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Format the pull request title like [MyPerf4J-XXX] Fix NullPointerException when host is null #XXX. Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
Run mvn clean package -Dmaven.test.skip=false to make sure unit-test pass.

MyPerf4J-Core/src/main/java/cn/myperf4j/core/MethodMetricsHistogram.java

MyPerf4J-Core/src/test/java/cn/myperf4j/core/FileTest.java

MyPerf4J-Core/src/main/java/cn/myperf4j/core/MethodMetricsHistogram.java

MyPerf4J-Core/src/test/java/cn/myperf4j/core/FileTest.java

LinShunKang · 2023-04-14T03:44:15Z

MyPerf4J-Core/src/test/java/cn/myperf4j/core/FileTest.java

+                fileWriter.write("#This is a file automatically generated by MyPerf4J, please do not edit!\n");
+                fileWriter.flush();
+                // 流还没释放导致
+                Assert.assertFalse(tmpFilePath.toFile().renameTo(testFilePath1.toFile()));


在 MacOS 里这行代码执行失败

你之前的代码在 MacOS 里能成功吗？

LinShunKang · 2023-04-14T03:44:25Z

MyPerf4J-Core/src/test/java/cn/myperf4j/core/FileTest.java

+                Assert.assertTrue(testFilePath2.toFile().setReadOnly());
+            } else {
+                // 第一次rename能成功，后续就失败
+                Assert.assertFalse(tmpFilePath.toFile().renameTo(testFilePath2.toFile()));


在 MacOS 里这行代码执行失败

LinShunKang · 2023-04-14T03:54:15Z

MyPerf4J-Core/src/main/java/cn/myperf4j/core/MethodMetricsHistogram.java

+            final File tempFile = buildTmpProfilingFile(filePath);
+            final Path destPath = Files.move(tempFile.toPath(), Paths.get(filePath), REPLACE_EXISTING);
+            final File destFile = destPath.toFile();
+            // 此处不能设置只读，否则在windows环境下次move的时候会报错 AccessDeniedException


如果 destFile.setReadOnly() 之后再次 move 会报错的话，那 FileTest 的第 89 行就会抛异常

不一样，FileTest 能跑成功，但是 agent 加载到 tomcat 里面就会报错

Fix: fix SysGenProfilingFile rename fail

c5cab11