`services.aerospace.settings.on-window-detected` has the wrong type #1142

Sabinu · 2024-11-04T17:35:22Z

nix-darwin/modules/services/aerospace/default.nix

Line 73 in 189d2d4

on-window-detected = lib.mkOption {

https://nikitabobko.github.io/AeroSpace/guide#on-window-detected-callback

it is not a list of strings; it is a set with atributes: { x = 1; y = 2; }

Enzime · 2024-11-04T17:48:30Z

Could you make a PR?

teelahti · 2024-11-06T14:00:20Z

Similarly, workspace-to-monitor-force-assignment does not work even with the default configuration sample when inside services.aerospace.settings block. Nix complains about the data type:

error: syntax error, unexpected INT_LIT
at /nix/store/2ya55va8svjxbz5hrr5c17iykwgaf2a2-source/nix/hosts/mbp/default.nix:157:7:
   156|     workspace-to-monitor-force-assignment = {
   157|       1 = "1";

If I had to guess, this needs to be raised to be a property of its own, with correct data types.

dbozbay · 2024-11-29T19:37:48Z

Has anyone managed to parse into services.aerospace.settings.on-window-detected successfully? I can't figure out. Would love to completely ditch Aerospace via Homebrew + aerospace.toml and migrate to services.aerospace completely, but this is holding me back.

These are the settings from my aerospace.toml that I'm trying to implement in nix:

[[on-window-detected]]
if.app-id = 'company.thebrowser.Browser'
run = "move-node-to-workspace 1"

[[on-window-detected]]
if.app-id = 'com.mitchellh.ghostty'
run = 'move-node-to-workspace 2'

[[on-window-detected]]
if.app-id = 'com.apple.Music'
run = "move-node-to-workspace 3"

thuvasooriya · 2024-12-02T01:56:10Z

Has anyone managed to parse into services.aerospace.settings.on-window-detected successfully? I can't figure out. Would love to completely ditch Aerospace via Homebrew + aerospace.toml and migrate to services.aerospace completely, but this is holding me back.

#1168
this one fixes the issue by allowing multiple types, not sure if it's the nix way to do things, but it works for now. I think they haven't gotten around to merging it yet

trying to fix LnL7#1142

blindFS · 2024-12-02T04:55:50Z

Unrelated question, I have a long aerospace.toml file, is it possible to load it as services.aerospace.settings ?
let expression seems not allowed in flake.nix.

thuvasooriya · 2024-12-02T05:38:57Z

I have a long aerospace.toml file, is it possible to load it as services.aerospace.settings ?

I'm not sure if this is what you are asking, you can import a toml like this

  services.aerospace = {
    enable = true;
    settings = pkgs.lib.importTOML ../../config/aerospace.toml;
  };

blindFS · 2024-12-02T05:52:54Z

I have a long aerospace.toml file, is it possible to load it as services.aerospace.settings ?

I'm not sure if this is what you are asking, you can import a toml like this
  services.aerospace = {
    enable = true;
    settings = pkgs.lib.importTOML ../../config/aerospace.toml;
  };

Totally, thanks!

…n-window-detected type LnL7#1208 trying to fix LnL7#1142 testing requested changes adding workspace to monitor force assignment remove formatting tests pass proper tests undo formatting tests for on-window-detected and workspace-to-monitor-force-assignment testing submodules cleanup n if fiz checking final toml null field aerospace callback issue custom null filter for submodule list check for no presense of window-regex and if.workspace config check error

…n-window-detected type LnL7#1208 trying to fix LnL7#1142 testing requested changes adding workspace to monitor force assignment remove formatting tests pass proper tests undo formatting tests for on-window-detected and workspace-to-monitor-force-assignment testing submodules cleanup n if fiz checking final toml null field aerospace callback issue custom null filter for submodule list check for no presense of window-regex and if.workspace config check error formatting mishap

…n-window-detected type LnL7#1208 trying to fix LnL7#1142 testing requested changes adding workspace to monitor force assignment remove formatting tests pass proper tests undo formatting tests for on-window-detected and workspace-to-monitor-force-assignment testing submodules cleanup n if fiz checking final toml null field aerospace callback issue custom null filter for submodule list check for no presense of window-regex and if.workspace config check error formatting mishap space left

trying to fix LnL7#1142 testing requested changes adding workspace to monitor force assignment remove formatting tests pass proper tests undo formatting tests for on-window-detected and workspace-to-monitor-force-assignment testing submodules cleanup n if fiz checking final toml null field aerospace callback issue custom null filter for submodule list check for no presense of window-regex and if.workspace config check aerospace: add workspace-to-monitor-force-assignment option and fix on-window-detected type LnL7#1208 trying to fix LnL7#1142 testing requested changes adding workspace to monitor force assignment remove formatting tests pass proper tests undo formatting tests for on-window-detected and workspace-to-monitor-force-assignment testing submodules cleanup n if fiz checking final toml null field aerospace callback issue custom null filter for submodule list check for no presense of window-regex and if.workspace config check error formatting mishap space left

…n-window-detected type LnL7#1208 trying to fix LnL7#1142 testing requested changes adding workspace to monitor force assignment remove formatting tests pass proper tests undo formatting tests for on-window-detected and workspace-to-monitor-force-assignment testing submodules cleanup n if fiz checking final toml null field aerospace callback issue custom null filter for submodule list check for no presense of window-regex and if.workspace config check aerospace: add workspace-to-monitor-force-assignment option and fix on-window-detected type LnL7#1208 trying to fix LnL7#1142 testing requested changes adding workspace to monitor force assignment remove formatting tests pass proper tests undo formatting tests for on-window-detected and workspace-to-monitor-force-assignment testing submodules cleanup n if fiz checking final toml null field aerospace callback issue custom null filter for submodule list check for no presense of window-regex and if.workspace config check error formatting mishap space left small fix

…n-window-detected type LnL7#1208 trying to fix LnL7#1142 testing requested changes adding workspace to monitor force assignment remove formatting tests pass proper tests undo formatting tests for on-window-detected and workspace-to-monitor-force-assignment testing submodules cleanup n if fiz checking final toml null field aerospace callback issue custom null filter for submodule list check for no presense of window-regex and if.workspace config check aerospace: add workspace-to-monitor-force-assignment option and fix on-window-detected type LnL7#1208 trying to fix LnL7#1142 testing requested changes adding workspace to monitor force assignment remove formatting tests pass proper tests undo formatting tests for on-window-detected and workspace-to-monitor-force-assignment testing submodules cleanup n if fiz checking final toml null field aerospace callback issue custom null filter for submodule list check for no presense of window-regex and if.workspace config check error formatting mishap space left small fix formatting mishaps

talhaHavadar mentioned this issue Nov 14, 2024

aerospace: fix on-window-detected #1168

Open

Enzime changed the title ~~AEROSPACE SERVICE: on-window-detected options is not properly typed~~ services.aerospace.settings.on-window-detected has the wrong type Nov 15, 2024

thuvasooriya added a commit to thuvasooriya/nix-darwin that referenced this issue Dec 2, 2024

LnL7#1142 fix

40a7b40

thuvasooriya added a commit to thuvasooriya/nix-darwin that referenced this issue Dec 2, 2024

fix

c38f61a

trying to fix LnL7#1142

thuvasooriya mentioned this issue Dec 2, 2024

aerospace: add workspace-to-monitor-force-assignment option and fix on-window-detected type #1208

Merged

Enzime closed this as completed in #1208 Dec 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`services.aerospace.settings.on-window-detected` has the wrong type #1142

`services.aerospace.settings.on-window-detected` has the wrong type #1142

Sabinu commented Nov 4, 2024

Enzime commented Nov 4, 2024

teelahti commented Nov 6, 2024

dbozbay commented Nov 29, 2024 •

edited

Loading

thuvasooriya commented Dec 2, 2024

blindFS commented Dec 2, 2024

thuvasooriya commented Dec 2, 2024

blindFS commented Dec 2, 2024

services.aerospace.settings.on-window-detected has the wrong type #1142

services.aerospace.settings.on-window-detected has the wrong type #1142

Comments

Sabinu commented Nov 4, 2024

Enzime commented Nov 4, 2024

teelahti commented Nov 6, 2024

dbozbay commented Nov 29, 2024 • edited Loading

thuvasooriya commented Dec 2, 2024

blindFS commented Dec 2, 2024

thuvasooriya commented Dec 2, 2024

blindFS commented Dec 2, 2024

`services.aerospace.settings.on-window-detected` has the wrong type #1142

`services.aerospace.settings.on-window-detected` has the wrong type #1142

dbozbay commented Nov 29, 2024 •

edited

Loading