Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM Dependencies #19

Closed
wants to merge 1 commit into from
Closed

Update NPM Dependencies #19

wants to merge 1 commit into from

Conversation

zysim
Copy link
Contributor

@zysim zysim commented Aug 15, 2019

Closes: #11

This PR should solve any warnings we get on vulnerable dependencies.

Warning: This is still a WIP.

This is far from finished.
@zysim zysim self-assigned this Aug 15, 2019
@zysim
Copy link
Contributor Author

zysim commented Aug 16, 2019

Updating grunt to ^1.0.4, and grunt-contrib-jshint to ^2.1.0 solves a big majority of the dependency issues. However, three dev dependencies, grunt-imgcompress, grunt-newer, and grunt-surround needs grunt to be ~0.4.0. I could fork these dependencies and work from there.

My output:

npm WARN [email protected] requires a peer of grunt@~0.4.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of grunt@~0.4.1 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of grunt@~0.4.1 but none is installed. You must install peer dependencies yourself.

@takluyver
Copy link
Member

Forking them sounds like a lot of effort. I'd check whether we actually still need them (e.g. have they been folded into other packages), and are there newer alternatives which everyone now uses instead?

@zysim
Copy link
Contributor Author

zysim commented Aug 16, 2019

Yeah that's what I thought of too. @tsaoyu mind checking if we still need them? I'm going through them now myself too, but I may miss some things out.

@tsaoyu
Copy link
Member

tsaoyu commented Aug 21, 2019

I don't know if we need it or not. I setup this blog using made-mistakes template and they has updated the packages list to mitigate the security issue. Maybe worth to migrate to newer version.

@zysim
Copy link
Contributor Author

zysim commented Aug 21, 2019

I'll look at that this evening 👍

@zysim
Copy link
Contributor Author

zysim commented Aug 25, 2019

Going through Made Mistakes, there really doesn't seem to be an easy way to fix these vulnerabilities. The docs for that template itself says that we'd need to rework quite a bit of it in order to publish it to Github Pages. Case in point, it has a few plugins in its Gemfile that isn't allowed in Pages. On top of this, I'm struggling to even get the repo to build on my machine haha.

@zysim
Copy link
Contributor Author

zysim commented Aug 25, 2019

I should also mention that the NPM updates isn't as simple as updating the package.json in Made Mistakes.

@zysim zysim closed this Aug 25, 2019
@zysim zysim reopened this Aug 25, 2019
@takluyver
Copy link
Member

takluyver commented Aug 25, 2019 via email

@zysim
Copy link
Contributor Author

zysim commented Aug 25, 2019

Yeah that's true. Just thought I'd be able to tackle it :P

@zysim zysim closed this Aug 25, 2019
@zysim zysim deleted the updateDependencies branch March 2, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerability in dependencies
3 participants