Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongo-object NPM package as peer dependency #1742

Open
manueltimita opened this issue Jun 27, 2024 · 2 comments
Open

mongo-object NPM package as peer dependency #1742

manueltimita opened this issue Jun 27, 2024 · 2 comments

Comments

@manueltimita
Copy link

The package aldeed:simple-schema also depends on mongo-object. AutoForm is used in conjunction with SimplSchema more often than not. So both packages end up including the same dependency twice in the final bundle.

Any reasons not to use the peer npm meteor approach?

@jankapunkt I am happy to send a PR. I'm just checking whether there is a known issue / reason why this hasn't been done.

Copy link

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously.
Our goal is to provide long-term lifecycles for packages and keep up
with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time.
Therefore, we can't guarantee you issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit
a pull request, too! We will accompany you in the process with reviews and hints
on how to get development set up.

Please also consider sponsoring the maintainers of the package.
If you don't know who is currently maintaining this package, just leave a comment
and we'll let you know

@jankapunkt
Copy link
Member

Hi @manueltimita thanks for reporting. It makes sense, however I'm currently pinning the versions for compatibility as I have to review all changes and especially since they are not likely to be backwards compatible. A useful first approach would be to pin the versions with the npmDependencies package and then start to migrate to the latest possible versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants