-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Badge no longer displays after Turbo Drive page load w/ Turbo 8 (even w/ enable_hotwire_turbo_drive_support = true) #612
Comments
I dug into this a bit cause it's affecting our app as well. From what I can tell, Turbo 8 references and uses the native |
@joshuay03 Thanks for sharing! My spelunking was leaving me stumped. |
Apologies if this is self-evident and I'm not seeing the solution. What is the intended fix for this? If any. Thanks |
I think we can try removing the Edit: Tried this, didn't work. Hopefully someone who's more JS savvy can chime in. |
I've ran into this too in both a Rails 7 a Rails 8 app. Both are using recent versions of Turbo: 8.0.5 and 8.0.10 rack-mini-profiler-test-case.movYou can try it out here: |
Issue: After upgrading to Turbo 8 the Rack Mini Profiler badge no longer displays after a Turbo Drive action with Rack::MiniProfiler.config.enable_hotwire_turbo_drive_support = true. If I revert back to Turbo 7 / Turbo Rails 1.5 the behavior works as expected.
Expected Behavior: When a page loads with Turbo Drive the Rack Mini Profiler badge displays.
Actual Behavior: When a page loads with Turbo Drive the Rack Mini Profiler badge does not display.
The text was updated successfully, but these errors were encountered: