Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] What happened to FS3 (FileSystem)? #533

Open
laurenyew-nytimes opened this issue Mar 9, 2023 · 4 comments
Open

[Feature Request] What happened to FS3 (FileSystem)? #533

laurenyew-nytimes opened this issue Mar 9, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@laurenyew-nytimes
Copy link

Is your feature request related to a problem? Please describe.
We're looking into migrating from Store4 into Store 5. What happened to FS3 (FileSystem)? We were using this regularly for a persistence solution. Is this planning to be added back or was this removed for a particular reason?

Describe the solution you'd like
Documentation on migration path (if FS3 was removed, why, and suggestions on what to replace it with).
If FS3 is going to be added back in, an ETA on that.

Describe alternatives you've considered
We're looking into having to reimplement FS3 on our own, but if it's planning on being added back in, we don't want to duplicate work.

Additional context
N/A

@laurenyew-nytimes laurenyew-nytimes added the enhancement New feature or request label Mar 9, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Triage in Store Roadmap Mar 9, 2023
@matt-ramotar
Copy link
Collaborator

Hey there - Adding FileSystem sounds fine to me. Looking at its dependencies it shouldn't be a huge lift. Happy to put it on our roadmap as long as @digitalbuddha doesn't have any concerns

@matt-ramotar matt-ramotar moved this from 🆕 Triage to ℹ Investigating in Store Roadmap Mar 9, 2023
@digitalbuddha
Copy link
Contributor

No concerns or compat issues. Source of truth API has not changed we just need to add the module again. Pardon the mess. I'll try to get to it early next week

@aclassen
Copy link
Contributor

aclassen commented Mar 23, 2023

Just keep in mind that the FS3 implementation does not work correct using a non unix filesystem. For example https://github.com/aclassen/Store/blob/main/filesystem-kmp/src/commonMain/kotlin/com/dropbox/kmp/external/fs3/filesystem/FSFile.kt#L27
This is not true for windows , beside other limitations.
@laurenyew-nytimes as long there is no offical one you can also take a look at my fork but it's Store4.
I could also create a pr if needed , i updated it already to Store5

@laurenyew-nytimes
Copy link
Author

laurenyew-nytimes commented Mar 30, 2023

@aclassen We need it for Android only. @digitalbuddha Has FS3 been added into this repo in Store 5?

@matt-ramotar matt-ramotar added this to the Store 5 milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Investigating
Development

No branches or pull requests

4 participants