Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit data into collected stream after write or fetch with no SourceOfTruth #634

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

filanjuraj
Copy link

Closes #541

Description

Writing into Store doesnt emit data into collected stream (reading from Store), also when collecting stream with localOnly request. Happens only if you don't provide SourceOfTruth.

Steps to reproduce the behavior:

Writing into store:

  1. Start collecting stream (read from Store with key X)
  2. Write into Store new data with key X
  3. Collected stream doesnt receive the new data
  4. Start collecting stream again (read from store with key X) gives you the new data

Collecting stream with LocalOnly request:

  1. Start collecting strean with LocalOnly request with key X
  2. Fetch new data with key X
  3. Collected stream doesnt receive the new data
  4. Start collecting stream again (read from store with key X) gives you the new data

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Test Plan

Added new tests. Tested in sample app.

Checklist:

Before submitting your PR, please review and check all of the following:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my change is effective
  • New and existing unit tests pass locally with my changes

Additional Notes:

Add any other information about the PR here.

@filanjuraj filanjuraj force-pushed the fix_collecting_pr_1 branch from b55f0ba to 0518b22 Compare April 17, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 Triage
Development

Successfully merging this pull request may close these issues.

[BUG] Writing into Store doesnt emit data into collected flow
2 participants