Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortName to the EML211 model function serialize #2536

Open
vchendrix opened this issue Sep 20, 2024 · 1 comment · May be fixed by #2591
Open

Add shortName to the EML211 model function serialize #2536

vchendrix opened this issue Sep 20, 2024 · 1 comment · May be fixed by #2591
Assignees
Labels
bug ESS-DIVE Issues associated with the ESS-DIVE project
Milestone

Comments

@vchendrix
Copy link
Collaborator

Bug Description:
The shortName field is not being serialized in the EML211 model function serialize. This field should be included in the basicText array to ensure it is properly serialized. This issue prevents the generation of a default short name on create.

Location in Code:
The issue is located in the EML211 model function serialize in the metacatui/src/js/models/metadata/eml211/EML211.js file.

Current Code:

var basicText = ["alternateIdentifier", "title"];

Expected Behavior:
The shortName field should be serialized along with other basic text fields.

Steps to Reproduce

  1. Create an instance of the EML211 model.
  2. Set the shortName attribute.
  3. Call the serialize function.
  4. Observe that the shortName field is not included in the serialized output.

Suggested Fix

Ensure that the shortName field is included in the basicText array in the serialize function.

Additional Context

This issue affects the proper serialization of the shortName field in EML 2.1.1 documents, which may lead to incomplete metadata representation. This prevents the generation of a default short name on create.

@robyngit robyngit added this to the 2.32.0 milestone Sep 23, 2024
@robyngit robyngit self-assigned this Sep 23, 2024
@robyngit robyngit added bug ESS-DIVE Issues associated with the ESS-DIVE project labels Sep 23, 2024
@robyngit
Copy link
Member

Note: docs for the shortName EML element here

robyngit added a commit that referenced this issue Dec 17, 2024
Added shortname to the array of basic text elements

Fixes #2536
@robyngit robyngit linked a pull request Dec 17, 2024 that will close this issue
@robyngit robyngit linked a pull request Dec 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ESS-DIVE Issues associated with the ESS-DIVE project
Projects
None yet
2 participants