Validate orcids entered in the Editor #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new orcid validation method & associated tests Fixes issue #2553
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rushirajnenuji
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new orcid validation method as well as unit tests for that method.
This prevents users from saving orcids in the "People" section of the editor that are not valid.
Valid ORCIDs include:
source: orcid.org
However, when the EML is serialized, the ORCID will be standardized to the https format.
Note that the field for entering ORCIDs in the editor is actually the "userID" field in EML, and this technically allows for any sort of user ID. So ID strings which don't include "orcid.org" and which do not exactly follow the
0000-0000-0000-0000format are assumed to be another type of user ID and are assumed to be valid.To test these changes, try entering different orcids, both valid and invalid in the Editor. Also try saving. A user should not be able to save a dataset with an invalid orcid.
Closes #2553