-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make default template engine less forgiving about html parsing. #239
Comments
theengineear
added a commit
that referenced
this issue
Dec 22, 2024
Goals of the parser: * Tighten control over things like double-quotes & closing tags. * Improve error messaging for malformed markup. * Improve performance. Closes #239.
theengineear
added a commit
that referenced
this issue
Dec 22, 2024
Goals of the parser: * Tighten control over things like double-quotes & closing tags. * Improve error messaging for malformed markup. * Improve performance. Closes #239.
theengineear
added a commit
that referenced
this issue
Dec 23, 2024
Goals of the parser: * Tighten control over things like double-quotes & closing tags. * Improve error messaging for malformed markup. * Improve performance. Closes #239.
theengineear
added a commit
that referenced
this issue
Dec 23, 2024
Goals of the parser: * Tighten control over things like double-quotes & closing tags. * Improve error messaging for malformed markup. * Improve performance. Closes #239.
theengineear
added a commit
that referenced
this issue
Dec 27, 2024
Goals of the parser: * Tighten control over things like double-quotes & closing tags. * Improve error messaging for malformed markup. * Improve performance. Closes #239.
theengineear
added a commit
that referenced
this issue
Dec 28, 2024
Goals of the parser: * Tighten control over things like double-quotes & closing tags. * Improve error messaging for malformed markup. * Improve performance. Closes #239.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It’s common to leverage something like
setHTMLUnsafe
to let the browser parse arbitrary markup. However, this has to be incredibly forgiving as it needs to consider all current (and historic!) use cases. In general, the default template engine is not meant to serve such broad requirements. As such, it’s possible that it could benefit from significantly reducing it’s scope of concern — i.e., being less forgiving.Some potential wins:
The text was updated successfully, but these errors were encountered: