Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versioning #10

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix versioning #10

merged 2 commits into from
May 24, 2024

Conversation

sfoster1
Copy link
Member

We need to specify version metadata in this special annoying way where we specify the git describe command as well as the regex to find versions within the tag names.

You need to not only specify a tag pattern match but make sure that it's
not enclosed in quotes, AND make sure that setuptools_scm's git describe
command matches the tag prefix that you're configuring
@sfoster1 sfoster1 requested a review from a team as a code owner February 28, 2024 16:24
@sfoster1 sfoster1 merged commit c804887 into main May 24, 2024
12 checks passed
@sfoster1 sfoster1 deleted the fix-versioning branch May 24, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants