Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hackathon 7th No.56】rfc: 在 PaddleSpeech 中复现 DAC 训练需要用到的 loss #1029

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

suzakuwcx
Copy link

Copy link

paddle-bot bot commented Nov 30, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.


# 五、测试和验收的考量

- 首先在原 dac 仓库进行一次完完整的训练流程,抓出其中的多次经过 Loss 函数之后的输入和输出作为测试用例,在 tests/units/ 下新增 t2s 文件夹,同时添加文件 test_losses.py 作为单测, 单测必须全部通过
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

放tests/unit/tts里

- change 't2s' to 'tts'
- SISDRLoss is evaluate loss, not traning loss
Copy link
Contributor

@zxcd zxcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants