Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ribbon Implementation Does not Support "https" when using Eureka / Service Discovery #230

Closed
gmcouto opened this issue May 11, 2020 · 3 comments · May be fixed by #231
Closed

Ribbon Implementation Does not Support "https" when using Eureka / Service Discovery #230

gmcouto opened this issue May 11, 2020 · 3 comments · May be fixed by #231

Comments

@gmcouto
Copy link

gmcouto commented May 11, 2020

I had added reactive-feign to one of our most important micro-services in here, and we are using Eureka for Service Discovery.
All of our services register itself as only secure ports being enabled... and feign-reactive picks the 443 ports right away. However, it is still making calls using http scheme when using Ribbon (Cloud module).

We are unable to bump this microservice to Spring Boot 2.2, so we are still using Spring Boot 2.1 and cannot use Cloud 2 implementation that takes schema into account.

The current implementation for Ribbon in the cloud module is

  protected ReactiveHttpRequest loadBalanceRequest(ReactiveHttpRequest request, Server server) {
    URI lbUrl =
        UriComponentsBuilder.fromUri(request.uri())
            .host(server.getHost())
            .port(server.getPort())
            .build(true)
            .toUri();
    return new ReactiveHttpRequest(request, lbUrl);

So it uses the schema received from the ReactiveFeignClientFactoryBean that is hardcoded to use http only.

I can provide a PR that will take Eureka data into consideration and use it as the schema for this code.

@gmcouto
Copy link
Author

gmcouto commented May 11, 2020

PR is sent

@p4pramod
Copy link

Hi can you let me know which version of Feign Reactor WebClient has this fix?

@kptfh
Copy link
Collaborator

kptfh commented Apr 7, 2023

Reactive Feign client doesn't support Ribbon now, so will close issue.
Please create new ticket for Spring ReactiveLoadBalancer if it's still reproducible.

@kptfh kptfh closed this as completed Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants