Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schwarz: bool isFullyPeriodic() should not be a method inside the ccu mesh class #140

Open
fnrizzi opened this issue Jul 21, 2023 · 0 comments
Assignees

Comments

@fnrizzi
Copy link
Member

fnrizzi commented Jul 21, 2023

we need to move out the check if a mesh object is fully periodic because it has no mening if a mesh is a sample mesh.
the mesh class should only contain methods that make sense for a generic disjoint set of cells.
If we need to query whether the mesh is periodic, we can do so using a free function that accepts a mesh object and uses its connectivity.

@fnrizzi fnrizzi self-assigned this Jul 21, 2023
@fnrizzi fnrizzi changed the title bool isFullyPeriodic should not be a method inside the ccu mesh class schwarz: bool isFullyPeriodic should not be a method inside the ccu mesh class Jul 21, 2023
@fnrizzi fnrizzi added this to demoapps Jul 21, 2023
@github-project-automation github-project-automation bot moved this to Todo in demoapps Jul 21, 2023
@fnrizzi fnrizzi changed the title schwarz: bool isFullyPeriodic should not be a method inside the ccu mesh class schwarz: bool isFullyPeriodic() should not be a method inside the ccu mesh class Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant