Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2d diff reaction seems broken with openmp in Python #73

Open
fnrizzi opened this issue Jan 15, 2022 · 1 comment
Open

2d diff reaction seems broken with openmp in Python #73

fnrizzi opened this issue Jan 15, 2022 · 1 comment
Assignees
@fnrizzi
Labels
bug Something isn't working

Comments

@fnrizzi
Copy link
Member

fnrizzi commented Jan 15, 2022 •
edited
Loading

i get a segfault from the test
@fnrizzi fnrizzi self-assigned this Jan 15, 2022
@fnrizzi fnrizzi changed the title bug: 2d diff reaction seems broken with openmp in Python 2d diff reaction seems broken with openmp in Python Feb 1, 2022
@fnrizzi fnrizzi added the bug Something isn't working label Feb 1, 2022
@fnrizzi
Copy link
Member Author

fnrizzi commented Mar 30, 2022 •
edited
Loading

seem line the problem is due to passing a lambda from python and storing it into a std::function.
This does not play nicely with pybind when openmp is enabled

for now, diffusion-reaction2d is not parallelized for python:

#if defined PRESSIODEMOAPPS_ENABLE_OPENMP and not defined PRESSIODEMOAPPS_ENABLE_BINDINGS

fnrizzi added a commit that referenced this issue Mar 30, 2022
@fnrizzi
2d diff reac: temporarily omit openmp for python #73
252df0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnrizzi fnrizzi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fnrizzi