-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.20.2 and 1.20.3 missing metadataKeys in entities.json. #817
Comments
Also just looked and Burger also does not extract this info, so it might be manual. |
You can look at git blame info to find the commit that added it previously |
#710 info on how to extract |
Yeah, looks like it was not added to the doc. Running the extraction script in tools/js will generate it. The reason there is no test is that it's technically optional, as we don't have the data for all the versions. I guess a test could be done to check if versions newer than X have the field, but maybe the better solution would be to try and get all the data back. |
Personally I dont see as technically optional when mineflayer requires it to pass all its tests on current versions. I am looking into adding support in minecraft-data-generator-server. |
mineflayer is independent to minecraft-data, so what's optional in minecraft-data may indeed not be optional for mineflayer |
Adding more data validation and in general data quality tests to Minecraft data would definitely help. See PrismarineJS/prismarine-packet-dumper#82 (comment) as an example of what a quality report might look like |
Seems that the minecraft-data-generator-server doesn't output that information, and the tests don't check that it exists.
I will look into getting this information into the entities.json on both versions and look into if minecraft-data-generator-server can generate it.
The text was updated successfully, but these errors were encountered: