You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tile currently is only setting its background color when explicitly given a palette. Otherwise it allows the background of whatever its placed on to bleed through (this could be bad for accessibility)
Question:
With the implementation of theming tokens, should tile set it's color-palette="lightest" if left undefined.
Initial report:
Excerpt from
rh-tile.css
Tile currently is only setting its background color when explicitly given a palette. Otherwise it allows the background of whatever its placed on to bleed through (this could be bad for accessibility)
Question:
With the implementation of theming tokens, should tile set it's color-palette="lightest" if left undefined.
Excerpt from
rh-tile.ts
red-hat-design-system/elements/rh-tile/rh-tile.ts
Lines 127 to 136 in 33f88da
The comment, gives me pause. Base was a concept we haven't implemented. I'm assuming the code here was written to still fulfill this orphaned idea?
Should the fix be. If
color-palette
is undefined set tolightest
or in the css when
.light
or.dark
gets set to the#outer
and move that above the
& .palette-lightest - darkest
rules?Doing the later will cause a tile to always appear "darkest" on a dark parent context, unless overridden by setting its own color-palette.
The text was updated successfully, but these errors were encountered: