New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rustc's options parser as is #46

Open

CohenArthur opened this issue Jul 16, 2021 · 1 comment

Labels

Member

CohenArthur commented Jul 16, 2021

Maybe the parsing and the translation should be split? So the parsing would create a struct like https://github.com/rust-lang/rust/blob/456a03227e3c81a51631f87ec80cac301e5fa6d7/compiler/rustc_session/src/options.rs#L66-L71 (maybe even just copy this file verbatim? that way the parsing is guaranteed to be correct.) and then translation would create the appropriate arguments for gccrs.

Originally posted by @bjorn3 in #23 (comment)

CohenArthur added the enhancement label

Member Author

CohenArthur commented Jul 16, 2021

This is a big change, so I believe that it would be better to add it in a separate pull request once the refactor of GccrsArgs is complete.

This was referenced Jul 19, 2021

Handle --cfg and --cap-lints options #49

Merged

Refactor GccrsArgs structure #47

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment