Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.00.0 - RFC Ready - Major Base Change! #539

Closed
wants to merge 84 commits into from
Closed

2.00.0 - RFC Ready - Major Base Change! #539

wants to merge 84 commits into from

Conversation

lucasborin
Copy link
Member

@lucasborin lucasborin commented Dec 6, 2021

  • Enable RFC
  • Exemption based on TADIR/TRDIR/ENLFDIR gen flag
  • Renaming objects
  • Less global objects
  • Object creation date no longer uses the VRSD table
  • Option to evaluate new child objects
  • Performance optimization

** Migration Required **

⚠️ not supported in ABAP 7.40!

💡 after releasing it, change the master branch to main

lucasborin and others added 30 commits November 1, 2021 10:09
* adding quickfixes

* Less than 3 newlines and at least a single newline are required in between metho

* changelog

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: Eugen Günther <[email protected]>
* 1.16.0

* enabling changelog

* RAP needs CREATE OBJECT ... FOR TESTING (#448)

* resolves #444

* changelog

* COLLECT restrictions (#442)

* new check

* abapLint

* supporting programs

* closing gaps

* adding documentation

* Adding Changelog

* exempt ddic typed table

* supporting ddic table type

* supporting header line

* removing gap section

* supporting class attributes

* Use functional writing style for method calls

* Adding example

* Prefer Pragmas to Pseudo Comments (#446)

* new check

* new check

* documentation

* exempting SLIN

* Adding example

* Unit-Test Assert Validator (#450)

* Unit-Test Assert Validator 

resolve #449

* changelog

* BAdI example class vs Percentage Comment (#451)

* BAdI example class vs Percentage Comment

resolve #443

* changelog

* Allow Exemptions (#453)

* big refactoring

* isolating unit tests

* changelog

* forcing commit

* forcing commit

* Handle functional operand in assert check (#462)

* Functional operand check

* Fix unit test and nesting syntax

* Lint

* Update exemption unit test

* Fix unit test

* Add functional operand fix #460 to changelog

* removing static test, and adding more test cases

Co-authored-by: Lucas Borin <[email protected]>

* Unit Test on 752 (#463)

* fix #461

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Refactoring Code Pal (#457)

* saving progress

* saving progress

* Update changelog.txt

* global class vs local class

* local vs global test class

* Global Test Class fix

* enabling unit test

* refactoring y_check_function uts

* abaplint feedback

* abaplint feedback

* removing unecessary fields and fixing checksum

* fixing coverages (statement)

* default noaunit for test

* fixing bug in chain declaration

* fixing unit test

* Less than 3 newlines and at least a single newline are required in between metho

* ref #461

* solving conflict

* Update changelog.txt

* Update src/foundation/y_code_pal_ref_scan_double.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/foundation/y_code_pal_ref_scan_double.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fixing collect dump

* fixing pseudo comment dump and performance issue

* reusing refscan (performance)

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* pseudo comment refactoring (performance)

* collect (performance)

* Update changelog.txt

* Reorder definitions to top of routine

* pseudo_comment_usage ignore_pseudo

* more performance improvements

* removing deprecated methods

* activating prefer_inline (#465)

* activating prefer_inline

* Prefer Inline Declarations, PERCENTAGE

* Prefer Inline Declarations, RISK_LVL

* Prefer Inline Declarations, HAS_REDIRECTION

* Prefer Inline Declarations, TITLE

* Prefer Inline Declarations, CLASS_SEARCH_STRING

Co-authored-by: Lucas Borin <[email protected]>

* performance improvement (check statement pos)

* Prefer Inline Declarations, PROFILE_CONFIGURATIONS

* Line break multiple parameters

* Reorder definitions to top of routine

* Update changelog.txt

* magic number

* adding pseudo comments

* Adding pseudo comment

* Fixing magic number

* Use | to assemble text!

* Use | to assemble text!

* Prefer RETURNING to EXPORTING!

* Prefer LINE_EXISTS or LINE_INDEX to READ TABLE or LOOP AT!

* Prefer IS NOT to NOT IS!

* replacing pseudo

* removing unecessary pseudos

* unecessary pseudo

* clean coding f4call

* new SAP note dependency

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* use native *_wa variables (#475)

* resolves #474

* changelog

* forcing commit

* restore

Co-authored-by: Lucas Borin <[email protected]>

* disabling abaplint check_syntax

* Magic Number: Table Index  (#477)

* resolves #474

* fix #475

* fixing case

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Prefer New to Create Object: Dynamic Type (#478)

* Fixes #469

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Magic Number: Leading Zeros (#479)

* fixing magic number for leading zeros

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Magic Number: CASE SY-TABIX and CO NUMBERS (#480)

* case sy-tabix and Co numbers

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Y_CHECK_FORM: Screen Events (#482)

* Fixes #454

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Empty Catch: Test Double Framework (#483)

* Fixes #332

* Missing space between string or character literal and parentheses

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* line_exists does not support the operator IN (#485)

* Fixes #484

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Alternative Pseudo Comment (#486)

* saving progress

* saving progress

* saving progress

* alternative pseudo

* fixing 7.40 compatibility

* 7.40 compatibility

* revert checksum

* adjusting pseudo comment usage

* adding unit tests

* Missing space between string or character literal and parentheses

* new pseudo comment

* changelog

* alt_pcom in ut

* Update empty_catch.md

Co-authored-by: Lucas Borin <[email protected]>

* Chain Declaration for Complex Structures (#488)

* new test scope

* fixes #466

* cleaning self-reference

* cleaning chain declaration

* cleaning chain declaration

* cleaning chain declaration

* fixing syntax error

* changelog

* documentation

Co-authored-by: Lucas Borin <[email protected]>

* fixing syntax error

* `Y_CHECK_MESSAGE_EASY_TO_FIND` dump (#492)

* fixes #491

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* short review (#493)

Co-authored-by: Lucas Borin <[email protected]>

* Prefer Pragmas to Pseudo Comments (#495)

* fixes #489

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Pseudo Comment Usage: Multiple Inline Entries (#496)

* fixes #494

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Skip `Prefer RETURNING to EXPORTING` when both exist (#497)

* fixes #490

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* DB Access in UT: Local Inheritance (#498)

* partially solves #433

* changelog

* renaming variable

Co-authored-by: Lucas Borin <[email protected]>

* DB Access in UT: Global Inheritance (#500)

* fixes #433

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* fixing short dump (#501)

Co-authored-by: Lucas Borin <[email protected]>

* removing unecessary pseudo comment

* Prefer New: Dynamic Call with Parameters (#503)

* fixes #502

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* mass change of check data

* Update changelog.txt

* UI finetuning

* minor change

* abaplint compliance

* abaplint picky compliance

* UI Changes

* Revert "UI Changes"

This reverts commit cac373d.

* UI Changes

* small UI adjustments

* Update changelog.txt

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: Mike Pokraka <[email protected]>
Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
* quickfixes are now mandatory

* first check + message

* no quickfix

* wip

* implementing abstract method

* pseudo comments won't enable the quickfix

* removing unnecessary :

* removing duplicated quick fix

* changelog

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: Eugen Günther <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
lucasborin and others added 3 commits December 13, 2021 08:14
@lucasborin lucasborin marked this pull request as ready for review December 20, 2021 11:31
@lucasborin lucasborin marked this pull request as draft December 20, 2021 11:31
@lucasborin
Copy link
Member Author

lucasborin commented Dec 20, 2021

Performance test:

  • 91 objects = ~9.5s = 63% ABAP, 37% DB (CLAS only)
  • 744 objects = ~162s = 80% ABAP, 20% DB (FUGR, CLAS, and PROG)

@abap-weasel
Copy link

Just found the new branch after tweet from Thomas and noticed the warning not supported in ABAP 7.40.
Is this just temporary during development of V2 or will V2 also not run in 7.40 after release? (this will block us from using code-pal.... )

@ghost ghost changed the title 2.00.0 2.00.0 - RFC Ready - Major Base Change! Feb 8, 2022
@ConjuringCoffee ConjuringCoffee mentioned this pull request Aug 16, 2023
@bjoern-jueliger-sap
Copy link
Member

This will not be finished or merged; for a remote-enabled version of Code Pal, use our Cloud version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants