Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move enumerations into a separate module #1825

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Move enumerations into a separate module #1825

merged 1 commit into from
Oct 10, 2024

Conversation

dcermak
Copy link
Collaborator

@dcermak dcermak commented Oct 9, 2024

Having the enums in a separate module allows us to import it in other modules without having import cycles, split out of #1815

dcermak pushed a commit that referenced this pull request Oct 9, 2024
dcermak pushed a commit that referenced this pull request Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-1825
Changes pushed to branch 7-1825 as commit a7450c0b5af78cfe3f3c360cf8969b791a4ec71a
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-1825 for x86_64: current state: published
Build results:

package name status build log
sac-postfix-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-1825 for aarch64: current state: published
Build results:

package name status build log
sac-postfix-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-1825 for s390x: current state: published
Build results:

package name status build log
sac-postfix-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-1825 for ppc64le: current state: published
Build results:

package name status build log
sac-postfix-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-1825 for x86_64: current state: published
Build results:

package name status build log
sac-postfix-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-1825 for aarch64: current state: published
Build results:

package name status build log
sac-postfix-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-1825 for s390x: current state: published
Build results:

package name status build log
sac-postfix-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-1825 for ppc64le: current state: published
Build results:

package name status build log
sac-postfix-image ⛔ excluded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.7 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-1825/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-1825/containerfile/containers/postfix:3.8
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

Copy link

github-actions bot commented Oct 9, 2024

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1825
Changes pushed to branch 6-1825 as commit 1d559db2a9bca82052c299a4ecd0017fb65e610c
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1825 for x86_64: current state: published
Build results:

package name status build log
base-fips-image ⛔ excluded live log
sac-postfix-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1825 for aarch64: current state: published
Build results:

package name status build log
base-fips-image ⛔ excluded live log
sac-postfix-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1825 for s390x: current state: published
Build results:

package name status build log
base-fips-image ⛔ excluded live log
sac-postfix-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1825 for ppc64le: current state: published
Build results:

package name status build log
base-fips-image ⛔ excluded live log
sac-postfix-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1825 for x86_64: current state: published
Build results:

package name status build log
base-fips-image ✅ succeeded live log
sac-postfix-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1825 for aarch64: current state: published
Build results:

package name status build log
base-fips-image ✅ succeeded live log
sac-postfix-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1825 for s390x: current state: published
Build results:

package name status build log
base-fips-image ✅ succeeded live log
sac-postfix-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1825 for ppc64le: current state: published
Build results:

package name status build log
base-fips-image ✅ succeeded live log
sac-postfix-image ⛔ excluded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1825/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1825/containerfile/bci/bci-base-fips:latest
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1825/containerfile/containers/postfix:3.8
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

dcermak pushed a commit that referenced this pull request Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1825
Changes pushed to branch Tumbleweed-1825 as commit 1e42f0deff10305ee8154132263362ef9e7f2376
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

@dirkmueller
Copy link
Member

where is this going to be imported as well? also all the usages in bci_build.package.* are not updated to import directly rather than via bci_build.package.

is there a better name than "constants?" e.g. os_version/osversion is also a "constant" in that sense. maybe "attributes" or "containerattributes" ?

Having the enums in a separate module allows us to import it in other modules
without having import cycles
@dcermak
Copy link
Collaborator Author

dcermak commented Oct 10, 2024

where is this going to be imported as well?

I need the attributes in the obs_package module in #1815.

also all the usages in bci_build.package.* are not updated to import directly rather than via bci_build.package.

I have fixed that.

is there a better name than "constants?" e.g. os_version/osversion is also a "constant" in that sense. maybe "attributes" or "containerattributes" ?

I've picked container_attributes, thanks for the suggestion!

@dirkmueller dirkmueller merged commit 6158f6d into main Oct 10, 2024
9 checks passed
@dirkmueller dirkmueller deleted the move-enums branch October 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants