-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move enumerations into a separate module #1825
Conversation
Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-1825 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.7 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-1825/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1825 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1825/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1825 |
where is this going to be imported as well? also all the usages in bci_build.package.* are not updated to import directly rather than via bci_build.package. is there a better name than "constants?" e.g. os_version/osversion is also a "constant" in that sense. maybe "attributes" or "containerattributes" ? |
Having the enums in a separate module allows us to import it in other modules without having import cycles
I need the attributes in the
I have fixed that.
I've picked |
Having the enums in a separate module allows us to import it in other modules without having import cycles, split out of #1815