Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl container image (jsc#PED-11241) #2060

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

kubectl container image (jsc#PED-11241) #2060

wants to merge 1 commit into from

Conversation

rcmadhankumar
Copy link
Contributor

No description provided.

dcermak pushed a commit that referenced this pull request Nov 26, 2024
Test build for #2060
cbfbe10
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2060
Changes pushed to branch Tumbleweed-2060 as commit 5fc6154e55dac265d8dc44ccf2196fc0c3c90a5f
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2060/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2060/containerfile/opensuse/kubectl:latest

dirkmueller
dirkmueller requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

dcermak pushed a commit that referenced this pull request Nov 26, 2024
Test build for #2060
46b15ab
@rcmadhankumar rcmadhankumar force-pushed the kubectl-container branch 2 times, most recently from 15afdb8 to 5feb2ac Compare December 2, 2024 05:40
dcermak pushed a commit that referenced this pull request Dec 2, 2024
Test build for #2060
e6db72d
dcermak pushed a commit that referenced this pull request Dec 2, 2024
Test build for #2060
6fcb4e0
dcermak pushed a commit that referenced this pull request Dec 2, 2024
Test build for #2060
4380267
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-2060
Changes pushed to branch 6-2060 as commit e9b7cc171313a7ccac076f383a444e97e0204362
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for s390x: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for ppc64le: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for s390x: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2060 for ppc64le: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2060/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2060/containerfile/suse/kubectl:latest

dcermak pushed a commit that referenced this pull request Dec 2, 2024
Test build for #2060
b02eca5
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-2060
Changes pushed to branch 5-2060 as commit ead113196758e437809ea1837e07cc16308d3621
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for s390x: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for ppc64le: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for s390x: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-2060 for ppc64le: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.5 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-2060/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-2060/containerfile/suse/kubectl:1
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️ ⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-2060
Changes pushed to branch 7-2060 as commit 267297e91b140c9498496077ee6124e3b91e121d
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2060 for s390x: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2060 for ppc64le: current state: published
Build results:

package name status build log
kubectl-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2060 for x86_64: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2060 for aarch64: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2060 for s390x: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2060 for ppc64le: current state: published
Build results:

package name status build log
kubectl-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.7 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2060/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2060/containerfile/suse/kubectl:1

dirkmueller
dirkmueller requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments. the wrong package name is blocking

dcermak pushed a commit that referenced this pull request Dec 6, 2024
Test build for #2060
4028c1a
dcermak pushed a commit that referenced this pull request Dec 6, 2024
Test build for #2060
4fbad8f
dcermak pushed a commit that referenced this pull request Dec 6, 2024
Test build for #2060
21bc783
dcermak pushed a commit that referenced this pull request Dec 6, 2024
Test build for #2060
ead1131
@msmeissn
Copy link
Contributor

msmeissn commented Dec 6, 2024

Jira is jsc#PED-11241

dcermak
dcermak requested changes Dec 6, 2024
View reviewed changes
src/bci_build/package/kubectl.py Outdated Show resolved Hide resolved
src/bci_build/package/kubectl.py Outdated Show resolved Hide resolved
src/bci_build/package/kubectl/README.md.j2 Outdated Show resolved Hide resolved
src/bci_build/package/package_versions.json Outdated Show resolved Hide resolved
src/bci_build/package/kubectl.py Outdated Show resolved Hide resolved
@dirkmueller dirkmueller changed the title kubectl container image added kubectl container image (jsc#PED-11241) Dec 9, 2024
dirkmueller
dirkmueller approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the outstanding comments from @dcermak LGTM

dcermak pushed a commit that referenced this pull request Dec 10, 2024
Test build for #2060
f2f2535
dcermak pushed a commit that referenced this pull request Dec 10, 2024
Test build for #2060
5b33027
dcermak pushed a commit that referenced this pull request Dec 10, 2024
Test build for #2060
9366f93
alexandrevicenzi
alexandrevicenzi approved these changes Dec 10, 2024
View reviewed changes
src/bci_build/package/kubectl/README.md.j2 Outdated Show resolved Hide resolved
src/bci_build/package/kubectl/README.md.j2 Outdated Show resolved Hide resolved
dcermak pushed a commit that referenced this pull request Dec 11, 2024
Test build for #2060
e9b7cc1
dcermak pushed a commit that referenced this pull request Dec 11, 2024
Test build for #2060
5fc6154
dcermak pushed a commit that referenced this pull request Dec 11, 2024
Test build for #2060
267297e
@dirkmueller dirkmueller requested a review from dcermak December 17, 2024 08:37
dcermak
dcermak requested changes Dec 17, 2024
View reviewed changes
src/bci_build/package/kubectl.py
Comment on lines +45 to +58
("1.18", OsVersion.SP6),
("1.23", OsVersion.SP6),
("1.24", OsVersion.SP6),
("1.25", OsVersion.SP6),
("1.26", OsVersion.SP6),
("1.27", OsVersion.SP6),
("1.28", OsVersion.SP6),
("1.18", OsVersion.SP7),
("1.23", OsVersion.SP7),
("1.24", OsVersion.SP7),
("1.25", OsVersion.SP7),
("1.26", OsVersion.SP7),
("1.27", OsVersion.SP7),
("1.28", OsVersion.SP7),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho there's very little value in us shipping eol k8s client versions

Suggested change
("1.18", OsVersion.SP6),
("1.23", OsVersion.SP6),
("1.24", OsVersion.SP6),
("1.25", OsVersion.SP6),
("1.26", OsVersion.SP6),
("1.27", OsVersion.SP6),
("1.28", OsVersion.SP6),
("1.18", OsVersion.SP7),
("1.23", OsVersion.SP7),
("1.24", OsVersion.SP7),
("1.25", OsVersion.SP7),
("1.26", OsVersion.SP7),
("1.27", OsVersion.SP7),
("1.28", OsVersion.SP7),
("1.28", OsVersion.SP6),
("1.28", OsVersion.SP7),
("1.30", OsVersion.SP7),

src/bci_build/package/kubectl.py
pretty_name="kubectl",
custom_description="Kubernetes CLI for communicating with a Kubernetes cluster's control plane, using the Kubernetes API.",
os_version=os_version,
is_latest=os_version in CAN_BE_LATEST_OS_VERSION,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition is wrong: every SP6 & Tumbleweed container will be marked as latest

src/bci_build/package/kubectl.py
Comment on lines +11 to +12

KUBECTL_CONTAINERS = []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
KUBECTL_CONTAINERS = []

src/bci_build/package/kubectl.py
from_target_image=generate_from_image_tag(os_version, "bci-micro"),
tag_version=ver,
version_in_uid=False,
additional_versions=[format_version(ver, ParseVersion.MAJOR)],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho not a very useful version: all k8s-client container images now gets the additional tag kubectl:1. That doesn't allow you to distinguish between them

src/bci_build/package/kubectl.py

KUBECTL_CONTAINERS = [
ApplicationStackContainer(
name="kubectl",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must set a package_name. ATM all containers are called kubectl-image and we only create one image with the latest one created.

Suggested change
name="kubectl",
name="kubectl",
package_name=f"kubectl-{ver}-image",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcermak dcermak dcermak requested changes

@alexandrevicenzi alexandrevicenzi alexandrevicenzi approved these changes

@dirkmueller dirkmueller dirkmueller approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rcmadhankumar @msmeissn @dirkmueller @alexandrevicenzi @dcermak