Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop jshell as the CMD for openjdk-devel #2109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop jshell as the CMD for openjdk-devel #2109

wants to merge 1 commit into from

Conversation

dcermak
Copy link
Collaborator

@dcermak dcermak commented Dec 3, 2024

jshell is broken on ppc64le for mysterious reasons and it's not really a useful CMD anyway, so let's just stop using it by default until someone complains

dcermak pushed a commit that referenced this pull request Dec 3, 2024
Test build for #2109
cda8594
dcermak pushed a commit that referenced this pull request Dec 3, 2024
Test build for #2109
295b3f8
dcermak pushed a commit that referenced this pull request Dec 3, 2024
Test build for #2109
7c22fab
dcermak pushed a commit that referenced this pull request Dec 3, 2024
Test build for #2109
97eafb2
dcermak pushed a commit that referenced this pull request Dec 3, 2024
Test build for #2109
d857fb0
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-2109
Changes pushed to branch 5-2109 as commit 97eafb26c291ae22f3c077069a7164145966542f
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-2109 for x86_64: current state: published
Build results:

package name status build log
nodejs-18-image ⛔ excluded live log
openjdk-11-devel-image ⛔ excluded live log
openjdk-11-image ⛔ excluded live log
openjdk-17-devel-image ⛔ excluded live log
openjdk-17-image ⛔ excluded live log
postgres-15-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-2109 for aarch64: current state: published
Build results:

package name status build log
nodejs-18-image ⛔ excluded live log
openjdk-11-devel-image ⛔ excluded live log
openjdk-11-image ⛔ excluded live log
openjdk-17-devel-image ⛔ excluded live log
openjdk-17-image ⛔ excluded live log
postgres-15-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-2109 for s390x: current state: published
Build results:

package name status build log
nodejs-18-image ⛔ excluded live log
openjdk-11-devel-image ⛔ excluded live log
openjdk-11-image ⛔ excluded live log
openjdk-17-devel-image ⛔ excluded live log
openjdk-17-image ⛔ excluded live log
postgres-15-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-2109 for ppc64le: current state: published
Build results:

package name status build log
nodejs-18-image ⛔ excluded live log
openjdk-11-devel-image ⛔ excluded live log
openjdk-11-image ⛔ excluded live log
openjdk-17-devel-image ⛔ excluded live log
openjdk-17-image ⛔ excluded live log
postgres-15-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-2109 for x86_64: current state: published
Build results:

package name status build log
nodejs-18-image ✅ succeeded live log
openjdk-11-devel-image ✅ succeeded live log
openjdk-11-image ✅ succeeded live log
openjdk-17-devel-image ✅ succeeded live log
openjdk-17-image ✅ succeeded live log
postgres-15-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-2109 for aarch64: current state: published
Build results:

package name status build log
nodejs-18-image ✅ succeeded live log
openjdk-11-devel-image ✅ succeeded live log
openjdk-11-image ✅ succeeded live log
openjdk-17-devel-image ✅ succeeded live log
openjdk-17-image ✅ succeeded live log
postgres-15-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-2109 for s390x: current state: published
Build results:

package name status build log
nodejs-18-image ✅ succeeded live log
openjdk-11-devel-image ✅ succeeded live log
openjdk-11-image ✅ succeeded live log
openjdk-17-devel-image ✅ succeeded live log
openjdk-17-image ✅ succeeded live log
postgres-15-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-2109 for ppc64le: current state: published
Build results:

package name status build log
nodejs-18-image ✅ succeeded live log
openjdk-11-devel-image ✅ succeeded live log
openjdk-11-image ✅ succeeded live log
openjdk-17-devel-image ✅ succeeded live log
openjdk-17-image ✅ succeeded live log
postgres-15-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.5 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-2109/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-2109/containerfile/bci/node:18
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-2109/containerfile/bci/nodejs:18
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-2109/containerfile/bci/openjdk:11
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-2109/containerfile/bci/openjdk-devel:11
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-2109/containerfile/suse/postgres:15
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️ ⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Created a staging project on OBS for 16.0: home:defolos:BCI:Staging:16.0:16.0-2109
Changes pushed to branch 16.0-2109 as commit d857fb06d1c8a4a46e57536d8d9ca81c2e48803a
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:16.0:16.0-2109 for x86_64: current state: published
Build results:

package name status build log
gcc-14-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:16.0:16.0-2109 for aarch64: current state: published
Build results:

package name status build log
gcc-14-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:16.0:16.0-2109 for s390x: current state: published
Build results:

package name status build log
gcc-14-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:16.0:16.0-2109 for ppc64le: current state: published
Build results:

package name status build log
gcc-14-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:16.0:16.0-2109 for x86_64: current state: published
Build results:

package name status build log
gcc-14-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:16.0:16.0-2109 for aarch64: current state: published
Build results:

package name status build log
gcc-14-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:16.0:16.0-2109 for s390x: current state: published
Build results:

package name status build log
gcc-14-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:16.0:16.0-2109 for ppc64le: current state: published
Build results:

package name status build log
gcc-14-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=16.0 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/16.0/16.0-2109/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/16.0/16.0-2109/containerfile/bci/gcc:14
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️ ⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-2109
Changes pushed to branch 7-2109 as commit 7ce1025c28996c72f1a4e368ebf62024cf34e02b

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-2109
Changes pushed to branch 6-2109 as commit 9544a221fc1c4b5fe64fda623cec92aed7cb3eb9
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2109 for x86_64: current state: published
Build results:

package name status build log
openjdk-21-devel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2109 for aarch64: current state: published
Build results:

package name status build log
openjdk-21-devel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2109 for s390x: current state: published
Build results:

package name status build log
openjdk-21-devel-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2109 for ppc64le: current state: published
Build results:

package name status build log
openjdk-21-devel-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2109 for x86_64: current state: published
Build results:

package name status build log
openjdk-21-devel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2109 for aarch64: current state: published
Build results:

package name status build log
openjdk-21-devel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2109 for s390x: current state: published
Build results:

package name status build log
openjdk-21-devel-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2109 for ppc64le: current state: published
Build results:

package name status build log
openjdk-21-devel-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2109/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2109/containerfile/bci/openjdk-devel:latest
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

dirkmueller
dirkmueller previously requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@dirkmueller dirkmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be limiting that change to sle16 or sle15-sp7+, and not change behavior in a maintenance update without any good reason (and ppc64le is not a good reason).

also the README needs adjustments.

dcermak added a commit to SUSE/BCI-tests that referenced this pull request Dec 3, 2024
@dcermak
Don't check that jshell is the CMD on SLE 15 SP6+
084a0e9 
PR for SUSE/BCI-dockerfile-generator#2109
@dcermak dcermak mentioned this pull request Dec 3, 2024
Draft
dcermak pushed a commit that referenced this pull request Dec 3, 2024
Test build for #2109
9544a22
dcermak pushed a commit that referenced this pull request Dec 3, 2024
Test build for #2109
4d2649d
@dcermak
Drop jshell as the CMD for openjdk-devel on SP6+
db025ec 
jshell is broken on ppc64le for mysterious reasons and it's not really a useful
CMD anyway, so let's just stop using it by default until someone complains
@dcermak dcermak requested a review from dirkmueller December 20, 2024 10:11
@dcermak dcermak dismissed dirkmueller’s stale review December 20, 2024 10:12

has been adressed

dcermak pushed a commit that referenced this pull request Dec 20, 2024
Test build for #2109
7ce1025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrevicenzi alexandrevicenzi alexandrevicenzi approved these changes

@dirkmueller dirkmueller Awaiting requested review from dirkmueller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcermak @dirkmueller @alexandrevicenzi