Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCTEAM-1303: Securing systemd services #371

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

Amrita42
Copy link
Contributor

Description

Describe the overall goals of this pull request.
The scope is re-haul the existing article and add more content.

Are there any relevant issues/feature requests?

DOCTEAM-1303

Is this (based on) existing content?

Yes , based on existing content
https://documentation.suse.com/smart/security/html/systemd-securing/index.html#systemd-securing-techniques

@Amrita42 Amrita42 requested a review from taroth21 October 30, 2024 08:40
@Amrita42 Amrita42 changed the title [WIP]DOCTEAM-1303: Securing systemd services DOCTEAM-1303: Securing systemd services Oct 30, 2024
@Amrita42 Amrita42 self-assigned this Oct 30, 2024
@Amrita42 Amrita42 added the WIP Work in progress. Do not merge! label Nov 7, 2024
Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amrita42 Many thanks! I'm struggling a bit with section 2. (id="systemd-example-secure-service") and section 2.1 (id="improving-overall-exposure") in the article (see remarks). 2.1 is a 'lone section' (there is no 2.2 or 2.3) which the style guide suggests to avoid. Maybe you can find a way to solve that.

concepts/systemd-securing.xml Outdated Show resolved Hide resolved
tasks/systemd-example-secure-service.xml Outdated Show resolved Hide resolved
tasks/systemd-example-secure-service.xml Outdated Show resolved Hide resolved
<title>How to improve the overall exposure with options?</title>
<para>Use the command <command>systemd-analyze security</command> to analyze the security settings of a
&systemd; service. For example: </para>
<screen>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same example like in the previous section (which is good in terms of consistency) but if you have a look at the PDF or HTML output both examples follow each other directly (end of p.4 and beginning of p.5). Therefore it looks to reader like content that is duplicated without a good reason. I would rather omit the example output here and instead give show how to run the systemd-analyze security command with one of the following options (so the readers have a concrete example to cling to before you give them the reference list of options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here my intention was to highlight the previous example output and how to make it safe using the options .

I think based on more research , I will re-work this part and add more

tasks/systemd-example-secure-service.xml Show resolved Hide resolved
tasks/systemd-example-secure-service.xml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress. Do not merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants