Add system token for PAYG systems #1206
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjschwei
reviewed
Aug 19, 2024
| hostname: params[:hostname], | ||
| system_information: system_information, | ||
| proxy_byos_mode: :payg, | ||
| system_token: SccProxy.get_instance_id(request.request_parameters) |
There was a problem hiding this comment.
I see that get_instance_id makes some assumptions that are specific to our implementation of the verification plugin and that are probably not documented. This goes hand in hand with #1207 and should first be discussed with PM as to what the behavior should be and then we should do the implementation based on business needs/agreements rather than more or less randomly implement changes where there is a good chance that we do not fully understand the implications.
There was a problem hiding this comment.
will convert both PRs into drafts until a decision has been made then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
system-tokentoPAYGsystemsHow to test
Create a PAYG system, in the RMT the system token value should be the instance ID
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Review
Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.