-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait with 2.0.0 release please #186
Comments
If you want to look at some of the changes I did to a previous version of I am splitting those up right now, so I can create seperate PRs for the changes (as I should have done from the start). |
Great work, @jonasbadstuebner . How much time will it take for you to create a separate PR for the changes? |
I am already on it. |
We wanted more control over the list view, so we have removed that package. For now, you can skip those features/changes. We might not be able to merge every PR in this version. I suggest creating only those PRs that are essential for this version and easy to include. |
I'm trying to pick the different versions into PRs that make sense when separated. |
I will combine them a little bit because it would take a lot of time to split everything up and test the individual changes. I hope that's okay. |
Is it a requirement that the code is working after every commit? |
Yes, it is required as we might not include some of the changes in the release. For now, I have created a separate PR for renaming 'sendBy' to 'sentBy' in the Message class. PR #188 |
Alright thank you |
A new version has been released. |
Huh? Why. |
I guess I will still open the remaining PRs, but I don't really understand why this had to be rushed now... |
We were actually getting a lot of requests for the release, and I believe most of your changes are available in this release except for column one. which will not be breaking changes so we will surely release this in the next version. |
Okay, I get that the pressure was high. I will continue creating PRs and you let me know what you think - because I have dynamic swiping on my agenda for example, which could be a breaking change, I don't know. |
Is your feature request related to a problem? Please describe.
I currently have some changes I would like to get merged before 2.0.0 is released - because some of them are breaking changes. But they are very helpful IMO
Describe the solution you'd like
Don't officially release 2.0.0 just yet.
Describe alternatives you've considered
Keep the changes to myself, because they would break stuff for other users.
Additional context
I saw the release notes for 2.0.0 and my PRs will add more migration guide instructions, because they are breaking.
The text was updated successfully, but these errors were encountered: