Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait with 2.0.0 release please #186

Closed
jonasbadstuebner opened this issue Jun 12, 2024 · 14 comments · May be fixed by #187
Closed

Wait with 2.0.0 release please #186

jonasbadstuebner opened this issue Jun 12, 2024 · 14 comments · May be fixed by #187

Comments

@jonasbadstuebner
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I currently have some changes I would like to get merged before 2.0.0 is released - because some of them are breaking changes. But they are very helpful IMO

Describe the solution you'd like
Don't officially release 2.0.0 just yet.

Describe alternatives you've considered
Keep the changes to myself, because they would break stuff for other users.

Additional context
I saw the release notes for 2.0.0 and my PRs will add more migration guide instructions, because they are breaking.

@jonasbadstuebner
Copy link
Contributor Author

If you want to look at some of the changes I did to a previous version of flutter_chatview, you can compare my main branch here

I am splitting those up right now, so I can create seperate PRs for the changes (as I should have done from the start).
This takes some hours, so I wanted to open this issue to ask you to wait a little, until I opened my PRs and you reviewed them.

@vatsaltanna-simformsolutions
Copy link
Collaborator

Great work, @jonasbadstuebner . How much time will it take for you to create a separate PR for the changes?

@jonasbadstuebner
Copy link
Contributor Author

I am already on it.
I have a question, why was #173 implemented like this? I added the following and this is now much harder to achieve:
main...jonasbadstuebner:flutter_chatview:main#diff-66c2246143fbe4d6fb906cb10653cb68220f76592926c8341b361fef3a867d1aR294-R295

@vatsaltanna-simformsolutions
Copy link
Collaborator

We wanted more control over the list view, so we have removed that package. For now, you can skip those features/changes. We might not be able to merge every PR in this version. I suggest creating only those PRs that are essential for this version and easy to include.

@jonasbadstuebner
Copy link
Contributor Author

I'm trying to pick the different versions into PRs that make sense when separated.
I'm focusing on breaking changes for now.

@jonasbadstuebner
Copy link
Contributor Author

I will combine them a little bit because it would take a lot of time to split everything up and test the individual changes. I hope that's okay.

@jonasbadstuebner
Copy link
Contributor Author

Is it a requirement that the code is working after every commit?
Because I did not test that (yet).

@vatsaltanna-simformsolutions
Copy link
Collaborator

Yes, it is required as we might not include some of the changes in the release. For now, I have created a separate PR for renaming 'sendBy' to 'sentBy' in the Message class. PR #188

@jonasbadstuebner
Copy link
Contributor Author

Alright thank you

@apurva010
Copy link
Collaborator

A new version has been released.

@jonasbadstuebner
Copy link
Contributor Author

Huh? Why.

@jonasbadstuebner
Copy link
Contributor Author

I guess I will still open the remaining PRs, but I don't really understand why this had to be rushed now...
Well...it's your choice in the end. Congratulations on launching v2.0.0! 🚀

@vatsaltanna-simformsolutions
Copy link
Collaborator

We were actually getting a lot of requests for the release, and I believe most of your changes are available in this release except for column one. which will not be breaking changes so we will surely release this in the next version.

@jonasbadstuebner
Copy link
Contributor Author

Okay, I get that the pressure was high. I will continue creating PRs and you let me know what you think - because I have dynamic swiping on my agenda for example, which could be a breaking change, I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants