This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Refactor Cryptosuites #315
Labels
enhancement
New feature or request
help wanted
Extra attention is needed
quality-of-life
sign-verify
The interface, as it stands, is promoting strong coupling across
CryptoSuiteProofType
and a signature algorithm (which is unclear in which interface it's defined). That makes it difficult to know what the expectations are when you're dealing with an implementation. Additionally, it's leaking implementation details because users will need to understand what implementation of the interface is being used.I think the root cause of this is that
CreateVerifyHash()
is part of theCryptoSuiteProofType
interface. Instead, what if there is a separate function with a parameter oftype
CryptoSuiteProofType
? If you need to specify whether the signing algo does digest within it, another method likeIsSignDigested() bool
toCryptoSuiteProofType
. WDYT?Originally posted by @andresuribe87 in #288 (comment)
The text was updated successfully, but these errors were encountered: