Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Determine whether Option::None fields should be serialized in Messages/Resources #38

Open
amika-sq opened this issue Dec 8, 2023 · 1 comment

Comments

@amika-sq
Copy link
Contributor

amika-sq commented Dec 8, 2023

In the tbDEX protocol spec, there are a lot of optional fields that can appear within a Resource/Message.

Currently, Rust will serialize those optional fields, even if they're empty. I don't believe that the spec explicitly defines if they should/shouldn't. We should come to resolution on this, and add in serialization skips for Option::None fields if they're necessary.

Link to comment with a few options on how we could handle this:
#37 (comment)

@mistermoe
Copy link
Member

good callout @amika-sq !

I don't believe that the spec explicitly defines if they should/shouldn't.

will surface this discussion today so we can resolve

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants