Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Written a function for Palindrome checker #12177

Closed
wants to merge 5 commits into from
Closed

Written a function for Palindrome checker #12177

wants to merge 5 commits into from
+52 −0

Conversation

sarveshsrinath
Copy link

Describe your change:

Adding a file which returns a boolean value when a phrase, word or an integer is palindromic.
Fixes #12165

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 19, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 19, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 19, 2024
@kunaldevsahu
Copy link

def isPalindrome(N):
n1=N
n2=0
while N!=0:
r=N%10
n2=n2*10 +r
N=N//10
if n1==n2:
return True
else:
return False

@tianyizheng02
Copy link
Contributor

Sorry, but we already have multiple algorithm files for checking different types of palindromes:
https://github.com/search?q=repo%3ATheAlgorithms%2FPython%20palindrome&type=code

We do not want duplicate algorithms in our repo. The issue #12165 should've never been opened in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A request to add a palindrome checker
3 participants
@sarveshsrinath @kunaldevsahu @tianyizheng02