Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inaccessible URL in computer_vision/README.md #12383

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Remove inaccessible URL in computer_vision/README.md #12383

merged 1 commit into from
Dec 28, 2024
+0 −1

Conversation

setbit123
Copy link
Contributor

@setbit123 setbit123 commented Nov 18, 2024 •
edited
Loading

Remove inaccessible URL.

Describe your change:

Remove an inaccessible URL in computer_vision/README.md Line 11.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes issue number".

Fixes #12382

@setbit123
Update computer_vision/README.md
10aa789 
Remove inaccessible URL.
@algorithms-keeper algorithms-keeper bot added documentation This PR modified documentation files awaiting reviews This PR is ready to be reviewed labels Nov 18, 2024
@setbit123
Copy link
Contributor Author

Additionally, I have attempted to search for the article using a similar title in DataRobot but did not retrieve any information.

@setbit123
Copy link
Contributor Author

@TheAlgorithms/python_maintainers You reviews, please.

@setbit123
Copy link
Contributor Author

Thank you for your approval. I notice that the PR has not been merged yet, and I would like to know if there is anything else I need to do to facilitate the merging of the PR.

cc @anandfresh

@setbit123 setbit123 requested a review from anandfresh November 23, 2024 06:08
@setbit123 setbit123 mentioned this pull request Dec 3, 2024
Closed
@tianyizheng02 tianyizheng02 changed the title Update computer_vision/README.md Remove inaccessible URL in computer_vision/README.md Dec 28, 2024
tianyizheng02
tianyizheng02 approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that the URL is dead. Thanks for the catch!

@tianyizheng02 tianyizheng02 merged commit d496d56 into TheAlgorithms:master Dec 28, 2024
5 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

@anandfresh anandfresh anandfresh approved these changes

Assignees
No one assigned
Labels
documentation This PR modified documentation files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] Remove inaccessible URL in computer_vision/README.md Line 11
3 participants
@setbit123 @anandfresh @tianyizheng02