Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Kadane's algothirm to array in data_structures folder #12224

Closed
Siddhart2004 opened this issue Oct 21, 2024 · 2 comments
Closed

Adding Kadane's algothirm to array in data_structures folder #12224

Siddhart2004 opened this issue Oct 21, 2024 · 2 comments
Labels
enhancement This PR modified some existing files

Comments

@Siddhart2004
Copy link

Feature description

📋** Topic**: Kadane's algothirm

Description

Kadane’s algorithm is a popular algorithm used to find the maximum sum of a contiguous subarray in an array with a time complexity of O(n). It efficiently handles both positive and negative numbers, making it an essential part of algorithmic problem-solving.
This algorithm can be a valuable addition to the project’s library under the "array" section, improving resources for learners and contributors.

I would like to work on this.
@Siddhart2004 Siddhart2004 added the enhancement This PR modified some existing files label Oct 21, 2024
@Siddhart2004 Siddhart2004 mentioned this issue Oct 21, 2024
Closed
15 tasks
@singhvibhanshu singhvibhanshu mentioned this issue Oct 21, 2024
Closed
15 tasks
@ankana2113 ankana2113 mentioned this issue Oct 24, 2024
Closed
15 tasks
@Christiansada

This comment was marked as off-topic.

Sign in to view
@medss19 medss19 mentioned this issue Dec 23, 2024
Closed
15 tasks
@tianyizheng02
Copy link
Contributor

We already have an implementation of Kadane's algorithm in dynamic_programming/max_subarray_sum.py. We do not want duplicate algorithms in our repo. If you wish to contribute an algorithm, please check the codebase first to see if it's already been implemented.

Furthermore, do not open issues to suggest algorithms, and do not ask to be assigned to an issue. This was made clear in our contributing guidelines, which you should've already read:

If you are interested in resolving an open issue, simply make a pull request with your proposed fix. We do not assign issues in this repo so please do not ask for permission to work on an issue.

Do not create an issue to contribute an algorithm. Please submit a pull request instead.

@tianyizheng02 tianyizheng02 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
3 participants
@tianyizheng02 @Siddhart2004 @Christiansada