Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining/Concatenating/Appending Axes #7

Open
1 of 6 tasks
Tokazama opened this issue Mar 2, 2020 · 1 comment
Open
1 of 6 tasks

Combining/Concatenating/Appending Axes #7

Tokazama opened this issue Mar 2, 2020 · 1 comment

Comments

@Tokazama
Copy link
Owner

Tokazama commented Mar 2, 2020

  • Finalize design:
    • Combine continuous collections (i.e., ranges):
      • Solution: grow from the last position (e.g., append_axis!(x, y) and cat(x, y) will grow from the last position of x.)
    • Combine discrete (non-continuous) collections:
      • Stack unique elements and make non-unique elements unique similar to how DataFrames.jl does
      • If there is no idiomatic solution then maybe just error and allow custom axis types for special use cases.
  • Document axis interface
  • Document customization with axes
  • Multidimensional (AbstractAxisIndices) examples

Biggest problem here is handling non-discrete values. I would much prefer a solution that doesn't default to an error and require users to create a custom axis type, but we have to ensure the solution doesn't hinder performance, make it difficult to understand for new users, or cause unexpected output.

@Tokazama
Copy link
Owner Author

Tokazama commented Mar 9, 2020

v0.2.0 begins to address this implementation more fully, but it still needs to be crowd tested before I feel like it's ready to finalize the examples and documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant