Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom out: when using to add a new page, inserter initially shows "no results found" #68232

Open
annezazu opened this issue Dec 23, 2024 · 2 comments · May be fixed by #68235
Open

Zoom out: when using to add a new page, inserter initially shows "no results found" #68232

annezazu opened this issue Dec 23, 2024 · 2 comments · May be fixed by #68235
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Per this recent work to use zoom out when adding a new page #63865 I noticed that initially, the inserter shows "no results found" before loading:

add.new.page.mov

Let's remove this!
@annezazu annezazu added [Feature] Zoom Out [Type] Bug An existing feature does not function as intended labels Dec 23, 2024
@SainathPoojary
Copy link
Contributor

SainathPoojary commented Dec 23, 2024 •
edited
Loading

Hey @annezazu ,
I was successfully able to reproduce the issue. I’ll work on a solution and open a draft PR shortly.

2024-12-23.13-04-36.mp4

@SainathPoojary SainathPoojary linked a pull request Dec 23, 2024 that will close this issue
Open
@Mamaduka Mamaduka added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced and removed [Feature] Zoom Out labels Dec 24, 2024
@Mamaduka
Copy link
Member

I believe loading state removal was intentional. See #67072.

cc @ellatrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inserter: Add loading state and refactor pattern SainathPoojary/gutenberg
3 participants
@Mamaduka @annezazu @SainathPoojary