Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn for missing composer.json file #829

Open
ernilambar opened this issue Dec 13, 2024 · 0 comments · May be fixed by #845
Open

Warn for missing composer.json file #829

ernilambar opened this issue Dec 13, 2024 · 0 comments · May be fixed by #845
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Check Proposal A new check proposal

Comments

@ernilambar
Copy link
Member

If plugin contains valid vendor folder generated by composer then it is recommended to add composer.json file in the plugin.

Using composer but could not find composer.json file

We noticed that your plugin is using Composer to handle library dependencies, that's great as it will help maintaining and updating your plugin in the future while avoiding collisions with other plugins that are using same libraries.

The composer.json file describes the dependencies of your project and may contain other metadata as well. It's a small file that typically can be found in the top-most directory of your plugin.

As one of the strengths of open source is the ability to review, observe, and adapt code, we would like to ask you to include that file in your plugin, even if it is only used for development purposes. This will allow others to exercise the open source freedoms from which we all benefit.

@ernilambar ernilambar added [Team] Plugin Review Issues owned by Plugin Review Team [Type] Check Proposal A new check proposal labels Dec 13, 2024
@ernilambar ernilambar linked a pull request Dec 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Check Proposal A new check proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant