Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving utils function name #643

Open
Daihecyy opened this issue Dec 23, 2024 · 0 comments · May be fixed by #641
Open

Improving utils function name #643

Daihecyy opened this issue Dec 23, 2024 · 0 comments · May be fixed by #641
Labels
code quality enhancement New feature or request

Comments

@Daihecyy
Copy link
Contributor

Subject of the issue

The function in utils/tool.py called is_user_member_of_an_allowed_group should really be renamed as the current name does not reflect what the function does anymore :

  • The cardinality is wrong as it can be used with multiple groups
  • The function is already used to check if member of a banned group

A possible new name could be is_user_member_of_groups_among(user, groups) but a better one could be found

@Daihecyy Daihecyy added enhancement New feature or request code quality labels Dec 23, 2024
@Daihecyy Daihecyy linked a pull request Dec 23, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant