Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a conda env as option for readers #506

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

volpatto
Copy link
Contributor

@volpatto volpatto commented Oct 26, 2019

Hi, @ageron!

First of all, congratulations for your great book!

I'm trying here to do a very small contributions in this PR, aiming for conda users (just like me). I'm adding an environment.yml with the same setup as requirements.txt. So, the user now can generate the same environment both for virtualenv (with the requirements.txt) and conda (with the new file).

To do so, one can just run:

$ conda env create -f environment.yml

An advantage with this contribution is the enhanced reproducibility. Also, it is easier for the user, since the user doesn't need to care about packages and versions (everything is already configured) A drawback is that when you update requirements.txt, you have to update environment.yml as well, to match packages' versions. Put it simply, both files have to be maintained.

I updated README with instructions. Please, do a double check there!

Thanks and I hope that you appreciate this PR!

@volpatto
Copy link
Contributor Author

volpatto commented Oct 26, 2019

Moreover, the problem mentioned by you in #369 can be solved if you have an environment.yml file in your repo (at least for Binder), I guess. So Binder will build automatically the environment.

@ageron
Copy link
Owner

ageron commented Oct 28, 2019

Hi @volpatto ,
That's really nice of you, thanks for the contribution! I already added an environment.yml file in the repository for the 2nd edition, but I didn't have time to add one for the 1st edition. Awesome! 👍

@ageron ageron merged commit 650ef07 into ageron:master Oct 28, 2019
@volpatto volpatto deleted the add-isolated-conda-envs branch October 28, 2019 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants