Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect keypoint array indexing in video_processing.py #101

Open
dannewbee opened this issue Aug 13, 2024 · 0 comments
Open

Incorrect keypoint array indexing in video_processing.py #101

dannewbee opened this issue Aug 13, 2024 · 0 comments

Comments

@dannewbee
Copy link

dannewbee commented Aug 13, 2024

Description

There is an issue in the crop_frames_and_get_transforms function in util/inference/video_processing.py. The keypoint array indexing is incorrect, which causes the keypoints to be appended to the wrong list. When target face count is set to be >1 (multiple faces), result video would be wrong.

Current Code

for q in range (len(target_embeds)):                
    kps_array[0].append([])

Suggested Fix

The indexing should be corrected to append the keypoints to the correct list:

for q in range (len(target_embeds)):                
    kps_array[q].append([])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant