Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong behavior on single subscription unsubscribe #88

Open
juffin-halli opened this issue Jul 25, 2024 · 0 comments
Open

Wrong behavior on single subscription unsubscribe #88

juffin-halli opened this issue Jul 25, 2024 · 0 comments
Assignees
Labels

Comments

@juffin-halli
Copy link

If you have only one subscription and then unsubscribe from it, Amp\Redis\RedisSubscriber will become to invalid state.
Amp\Redis\RedisSubscription::unsubscribe internally calls Amp\Redis\RedisSubscriber::unloadEmitter which checks isIdle and disconnects but runnging flag stays true. So, if you want to get another subscription after it, Amp\Redis\RedisSubscriber::run won't be called (and it will not perform connect therefore) and 'Redis connection already closed' exception will be thrown.

@kelunik kelunik added the bug label Jul 25, 2024
@kelunik kelunik self-assigned this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants