Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't parse Polish date with time #662

Open
jikamens opened this issue Nov 21, 2019 · 0 comments · May be fixed by #665
Open

Can't parse Polish date with time #662

jikamens opened this issue Nov 21, 2019 · 0 comments · May be fixed by #665

Comments

@jikamens
Copy link
Contributor

Sugar formats Polish datetimes as, e.g., "22 listopada 2019 0:00" but then can't parse the date that it just formatted. In particular, putting a time at the end of a Polish date/time string to be parsed breaks it.

I have started at the locale definitions for English and Polish until my eyes bleed, trying to figure out why English parses times at the end properly and Polish does not, and I can't figure it out. In particular, I can't see anything in the English definition that indicates that a time should be allowed at the end of a date, so I don't know what's missing from the Polish definition.

I am concerned that there has been no activity in this repository in many months. @andrewplummer are you still supporting this package? Can we expect fixes for the numerous open issues any time soon? Could you at least let us know what our expectations should be?
jikamens added a commit to jikamens/Sugar that referenced this issue Nov 21, 2019
@jikamens
Parse dd mmm yyyy hh:mm and weekday, dd mm yyyy hh:mm in Polish
f97aa12 
Fixes andrewplummer#662

I don't know if this is a complete fix because the date-parsing stuff
is quite arcane and I don't fully understand it, but this at least
seems to solve the problem of Sugar being unable to parse Polish dates
that it has itself formatted.
@jikamens jikamens linked a pull request Nov 21, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse dd mmm yyyy hh:mm and weekday, dd mm yyyy hh:mm in Polish jikamens/Sugar
1 participant
@jikamens