-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix incorrect path for types in index.d.ts #193
Open
amk-dev
wants to merge
1
commit into
anti-work:main
Choose a base branch
from
amk-dev:fix/incorrect-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@amk-dev is attempting to deploy a commit to the Antiwork Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@amk-dev thanks for the PR. Once you have the conflicts resolved I will test your branch and let you know. |
amk-dev
force-pushed
the
fix/incorrect-types
branch
from
December 27, 2024 22:28
8688d16
to
6684b32
Compare
just rebased. |
Why do we have a types folder within a types folder? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixs #191
Changes
Previously when the package is bundled,
index.d.ts
had incorrect paths for some imports. this makes theShortestConfig
from@antiwork/shortest
not resolve properly.here's the file structure of the published package ( i've removed irrelevent files from the tree )
so the imports in
index.d.ts
had two wrong imports./dist/types/test
./dist/types/config
both will not resolve, the correct paths are
./dist/types/types/test
./dist/types/types/config
this PR makes that update.
note: as discussed in the issue, there are room for improvement in the generation of
index.d.ts
. I'm gathering context for that. but since this is a rather important fix (imo). raising a PR.