You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow up from #3301, we should uniformize our Builder patterns. ApolloClient.Builder() especially has a bunch of Builder "shortcuts" that seemed interesting at first but end up creating issues:
deprecate (and ultimately remove) the intermediate builders
add ApolloClient.Builder.normalizedCacheInterceptor(), like there is retryInterceptor()
add ApolloClient.Builder.httpCacheInterceptor(), like there is retryInterceptor()
decide what to do with HttpNetworkTransport.newBuilder(). It could potentially be dangerous to create multiple instance sharing a single closeable resource. But it's possible anyways by reusing the original builder so we might as well decide to keep it with a bit warning.
Description
Follow up from #3301, we should uniformize our
Builder
patterns.ApolloClient.Builder()
especially has a bunch of Builder "shortcuts" that seemed interesting at first but end up creating issues:TODO:
ApolloClient.Builder.normalizedCacheInterceptor()
, like there isretryInterceptor()
ApolloClient.Builder.httpCacheInterceptor()
, like there isretryInterceptor()
HttpNetworkTransport.newBuilder()
. It could potentially be dangerous to create multiple instance sharing a single closeable resource. But it's possible anyways by reusing the original builder so we might as well decide to keep it with a bit warning.See #6287
See #6300
The text was updated successfully, but these errors were encountered: