Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builders management #6301

Open
6 tasks
martinbonnin opened this issue Dec 3, 2024 · 0 comments
Open
6 tasks

Builders management #6301

martinbonnin opened this issue Dec 3, 2024 · 0 comments

Comments

@martinbonnin
Copy link
Contributor

Description

Follow up from #3301, we should uniformize our Builder patterns. ApolloClient.Builder() especially has a bunch of Builder "shortcuts" that seemed interesting at first but end up creating issues:

TODO:

  • deprecate (and ultimately remove) the intermediate builders
  • add ApolloClient.Builder.normalizedCacheInterceptor(), like there is retryInterceptor()
  • add ApolloClient.Builder.httpCacheInterceptor(), like there is retryInterceptor()
  • decide what to do with HttpNetworkTransport.newBuilder(). It could potentially be dangerous to create multiple instance sharing a single closeable resource. But it's possible anyways by reusing the original builder so we might as well decide to keep it with a bit warning.
  • Add Kotlin builder-DSL helpers
  • update docs

See #6287
See #6300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant