Fix #4876 Refactored Show Brush Preview #4879
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
S4HRKBOY
force-pushed
the
BrushPreview_GlobalPreference
branch
from
cc7fce5 to
e3a2a4b
Compare
|
Hi there! One or more of the commit messages in this PR do not match our code submission policy, please check the |
|
clang-tidy review says "All clean, LGTM! 👍" |
S4HRKBOY
force-pushed
the
BrushPreview_GlobalPreference
branch
from
e3a2a4b to
f9ed1c9
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
| || m_docPref.show.brushPreviewInPreview())) { | ||
| (// 1) it doesn't contains the brush preview (e.g. the user | ||
| // is transforming the selection), | ||
| extraCel->purpose() != ExtraCel::Purpose::BrushPreview |
There was a problem hiding this comment.
warning: no header providing "app::ExtraCel" is directly included [misc-include-cleaner]
extraCel->purpose() != ExtraCel::Purpose::BrushPreview
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4876
Refactored brush Preview from DocPref to GlobalPref.