docs(ecr-assets): mention CDK_DOCKER environment variable in README #32586
Conversation
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
added
the
pr/needs-maintainer-review
Co-authored-by: Jimmy Gaussen <[email protected]>
kaizencc
changed the title
github-actions
bot
added
the
effort/small
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: Pull request #32586 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: 4 of 6 required status checks are expected.). You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio requeue |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
|
@aws/aws-cdk-owners should I just wait for getting this merged automatically or do I have anything to do here? |
|
Sorry :(. Will keep an eye out and get your PR merged |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32586 +/- ##
=======================================
Coverage 80.64% 80.64%
=======================================
Files 107 107
Lines 6994 6994
Branches 1290 1290
=======================================
Hits 5640 5640
Misses 1175 1175
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Issue # (if applicable)
Closes #32585.
Reason for this change
This change adds description that
CDK_DOCKERenvironment variable is also effective inaws-ecr-assetsmodule likeaws-s3-assets.Description of changes
Just a documentation change. No code change.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
I confirmed the environment variable is effective locally.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license